large refactor, fixes #2

server/internal/http/middleware/logger.go

@@ -61,13 +61,13 @@ func (e *entry) Write(status, bytes int, elapsed time.Duration) {
 	res["elapsed"] = float64(elapsed.Nanoseconds()) / 1000000.0
 
 	e.fields["res"] = res
-	e.fields["module"] = "api"
+	e.fields["module"] = "http"
 
 	if len(e.errors) > 0 {
 		e.fields["errors"] = e.errors
-		log.Error().Fields(e.fields).Msgf("Request failed (%d)", status)
+		log.Error().Fields(e.fields).Msgf("request failed (%d)", status)
 	} else {
-		log.Debug().Fields(e.fields).Msgf("Request complete (%d)", status)
+		log.Debug().Fields(e.fields).Msgf("request complete (%d)", status)
 	}
 }
 

server/internal/http/middleware/middleware.go

@@ -4,9 +4,9 @@ package middleware
 // a pointer so it fits in an interface{} without allocation. This technique
 // for defining context keys was copied from Go 1.7's new use of context in net/http.
 type ctxKey struct {
-	name string
+  name string
 }
 
 func (k *ctxKey) String() string {
-	return "neko/ctx/" + k.name
+  return "neko/ctx/" + k.name
 }

server/internal/http/middleware/recover.go

@@ -4,21 +4,21 @@ package middleware
 // https://github.com/zenazn/goji/tree/master/web/middleware
 
 import (
-	"net/http"
+  "net/http"
 
-	"n.eko.moe/neko/internal/http/endpoint"
+  "n.eko.moe/neko/internal/http/endpoint"
 )
 
 func Recoverer(next http.Handler) http.Handler {
-	fn := func(w http.ResponseWriter, r *http.Request) {
-		defer func() {
-			if rvr := recover(); rvr != nil {
-				endpoint.WriteError(w, r, rvr)
-			}
-		}()
+  fn := func(w http.ResponseWriter, r *http.Request) {
+    defer func() {
+      if rvr := recover(); rvr != nil {
+        endpoint.WriteError(w, r, rvr)
+      }
+    }()
 
-		next.ServeHTTP(w, r)
-	}
+    next.ServeHTTP(w, r)
+  }
 
-	return http.HandlerFunc(fn)
+  return http.HandlerFunc(fn)
 }

server/internal/http/middleware/request.go

@@ -1,14 +1,14 @@
 package middleware
 
 import (
-	"context"
-	"crypto/rand"
-	"encoding/base64"
-	"fmt"
-	"net/http"
-	"os"
-	"strings"
-	"sync/atomic"
+  "context"
+  "crypto/rand"
+  "encoding/base64"
+  "fmt"
+  "net/http"
+  "os"
+  "strings"
+  "sync/atomic"
 )
 
 // Key to use when setting the request ID.
@@ -37,19 +37,19 @@ var reqid uint64
 // than a millionth of a percent chance of generating two colliding IDs.
 
 func init() {
-	hostname, err := os.Hostname()
-	if hostname == "" || err != nil {
-		hostname = "localhost"
-	}
-	var buf [12]byte
-	var b64 string
-	for len(b64) < 10 {
-		rand.Read(buf[:])
-		b64 = base64.StdEncoding.EncodeToString(buf[:])
-		b64 = strings.NewReplacer("+", "", "/", "").Replace(b64)
-	}
+  hostname, err := os.Hostname()
+  if hostname == "" || err != nil {
+    hostname = "localhost"
+  }
+  var buf [12]byte
+  var b64 string
+  for len(b64) < 10 {
+    rand.Read(buf[:])
+    b64 = base64.StdEncoding.EncodeToString(buf[:])
+    b64 = strings.NewReplacer("+", "", "/", "").Replace(b64)
+  }
 
-	prefix = fmt.Sprintf("%s/%s", hostname, b64[0:10])
+  prefix = fmt.Sprintf("%s/%s", hostname, b64[0:10])
 }
 
 // RequestID is a middleware that injects a request ID into the context of each
@@ -58,32 +58,32 @@ func init() {
 // process, and where the last number is an atomically incremented request
 // counter.
 func RequestID(next http.Handler) http.Handler {
-	fn := func(w http.ResponseWriter, r *http.Request) {
-		ctx := r.Context()
-		requestID := r.Header.Get("X-Request-Id")
-		if requestID == "" {
-			myid := atomic.AddUint64(&reqid, 1)
-			requestID = fmt.Sprintf("%s-%06d", prefix, myid)
-		}
-		ctx = context.WithValue(ctx, RequestIDKey, requestID)
-		next.ServeHTTP(w, r.WithContext(ctx))
-	}
-	return http.HandlerFunc(fn)
+  fn := func(w http.ResponseWriter, r *http.Request) {
+    ctx := r.Context()
+    requestID := r.Header.Get("X-Request-Id")
+    if requestID == "" {
+      myid := atomic.AddUint64(&reqid, 1)
+      requestID = fmt.Sprintf("%s-%06d", prefix, myid)
+    }
+    ctx = context.WithValue(ctx, RequestIDKey, requestID)
+    next.ServeHTTP(w, r.WithContext(ctx))
+  }
+  return http.HandlerFunc(fn)
 }
 
 // GetReqID returns a request ID from the given context if one is present.
 // Returns the empty string if a request ID cannot be found.
 func GetReqID(ctx context.Context) string {
-	if ctx == nil {
-		return ""
-	}
-	if reqID, ok := ctx.Value(RequestIDKey).(string); ok {
-		return reqID
-	}
-	return ""
+  if ctx == nil {
+    return ""
+  }
+  if reqID, ok := ctx.Value(RequestIDKey).(string); ok {
+    return reqID
+  }
+  return ""
 }
 
 // NextRequestID generates the next request ID in the sequence.
 func NextRequestID() uint64 {
-	return atomic.AddUint64(&reqid, 1)
+  return atomic.AddUint64(&reqid, 1)
 }