remove config from capture managers.

internal/capture/broadcast.go

@@ -3,28 +3,27 @@ package capture
 import (
 	"fmt"
 	"sync"
+	"strings"
 
 	"github.com/rs/zerolog"
 	"github.com/rs/zerolog/log"
 
-	"demodesk/neko/internal/config"
 	"demodesk/neko/internal/capture/gst"
 )
 
 type BroacastManagerCtx struct {
 	logger       zerolog.Logger
 	mu           sync.Mutex
-	config    *config.Capture
+	pipelineStr  string
 	pipeline     *gst.Pipeline
 	enabled      bool
 	url          string
 }
 
-func broadcastNew(config *config.Capture) *BroacastManagerCtx {
+func broadcastNew(pipelineStr string) *BroacastManagerCtx {
 	return &BroacastManagerCtx{
 		logger:       log.With().Str("module", "capture").Str("submodule", "broadcast").Logger(),
-		mu:       sync.Mutex{},
+		pipelineStr:  pipelineStr,
-		config:   config,
 		enabled:      false,
 		url:          "",
 	}
@@ -68,30 +67,24 @@ func (manager *BroacastManagerCtx) Url() string {
 
 func (manager *BroacastManagerCtx) createPipeline() error {
 	if manager.pipeline != nil {
-		return fmt.Errorf("pipeline already running")
+		return fmt.Errorf("pipeline already exists")
 	}
 
 	var err error
 
+	// replace {url} with valid URL
+	pipelineStr := strings.Replace(manager.pipelineStr, "{url}", manager.url, 1)
+
 	manager.logger.Info().
-		Str("audio_device", manager.config.Device).
+		Str("str", pipelineStr).
-		Str("video_display", manager.config.Display).
+		Msgf("starting pipeline")
-		Str("broadcast_pipeline", manager.config.BroadcastPipeline).
-		Msgf("creating pipeline")
-
-	manager.pipeline, err = gst.CreateRTMPPipeline(
-		manager.config.Device,
-		manager.config.Display,
-		manager.config.BroadcastPipeline,
-		manager.url,
-	)
 
+	manager.pipeline, err = gst.CreatePipeline(pipelineStr)
 	if err != nil {
 		return err
 	}
 
 	manager.pipeline.Play()
-	manager.logger.Info().Msgf("starting pipeline")
 	return nil
 }
 
@@ -101,6 +94,6 @@ func (manager *BroacastManagerCtx) destroyPipeline() {
 	}
 
 	manager.pipeline.Stop()
-	manager.logger.Info().Msgf("stopping pipeline")
+	manager.logger.Info().Msgf("destroying pipeline")
 	manager.pipeline = nil
 }

internal/capture/gst/gst.go

@@ -39,35 +39,36 @@ func init() {
 	registry = C.gst_registry_get()
 }
 
-// CreateRTMPPipeline creates a GStreamer Pipeline
+func GetRTMPPipeline(audioDevice string, videoDisplay string, pipelineSrc string) string {
-func CreateRTMPPipeline(pipelineDevice string, pipelineDisplay string, pipelineSrc string, pipelineRTMP string) (*Pipeline, error) {
+	video := fmt.Sprintf(videoSrc, videoDisplay)
-	video := fmt.Sprintf(videoSrc, pipelineDisplay)
+	audio := fmt.Sprintf(audioSrc, audioDevice)
-	audio := fmt.Sprintf(audioSrc, pipelineDevice)
 
 	var pipelineStr string
 	if pipelineSrc != "" {
-		pipelineStr = fmt.Sprintf(pipelineSrc, pipelineRTMP, pipelineDevice, pipelineDisplay)
+		pipelineStr = fmt.Sprintf(pipelineSrc, audioDevice, videoDisplay)
 	} else {
-		pipelineStr = fmt.Sprintf("flvmux name=mux ! rtmpsink location='%s live=1' %s audio/x-raw,channels=2 ! audioconvert ! voaacenc ! mux. %s x264enc bframes=0 key-int-max=60 byte-stream=true tune=zerolatency speed-preset=veryfast ! mux.", pipelineRTMP, audio, video)
+		pipelineStr = fmt.Sprintf("flvmux name=mux ! rtmpsink location='{url} live=1' %s audio/x-raw,channels=2 ! audioconvert ! voaacenc ! mux. %s x264enc bframes=0 key-int-max=60 byte-stream=true tune=zerolatency speed-preset=veryfast ! mux.", audio, video)
 	}
 
-	return CreatePipeline(pipelineStr)
+	return pipelineStr
 }
 
-// CreateJPEGPipeline creates a GStreamer Pipeline
+func GetJPEGPipeline(videoDisplay string, pipelineSrc string, rate string, quality string) string {
-func CreateJPEGPipeline(pipelineDisplay string, pipelineSrc string, rate string, quality string) (*Pipeline, error) {
 	var pipelineStr string
 	if pipelineSrc != "" {
-		pipelineStr = fmt.Sprintf(pipelineSrc, pipelineDisplay)
+		pipelineStr = fmt.Sprintf(pipelineSrc, videoDisplay)
 	} else {
-		pipelineStr = fmt.Sprintf("ximagesrc display-name=%s show-pointer=true use-damage=false ! videoconvert ! videoscale ! videorate ! video/x-raw,framerate=%s ! jpegenc quality=%s" + appSink, pipelineDisplay, rate, quality)
+		pipelineStr = fmt.Sprintf("ximagesrc display-name=%s show-pointer=true use-damage=false ! videoconvert ! videoscale ! videorate ! video/x-raw,framerate=%s ! jpegenc quality=%s" + appSink, videoDisplay, rate, quality)
 	}
 
-	return CreatePipeline(pipelineStr)
+	return pipelineStr
+}
+
+func GetAppPipeline(codecRTP codec.RTPCodec, pipelineDevice string, pipelineSrc string) (string, error) {
+	if pipelineSrc != "" {
+		return fmt.Sprintf(pipelineSrc + appSink, pipelineDevice), nil
 	}
 
-// CreateAppPipeline creates a GStreamer Pipeline
-func CreateAppPipeline(codecRTP codec.RTPCodec, pipelineDevice string, pipelineSrc string) (*Pipeline, error) {
 	var pipelineStr string
 
 	switch codecRTP.Name {
@@ -75,7 +76,7 @@ func CreateAppPipeline(codecRTP codec.RTPCodec, pipelineDevice string, pipelineS
 		// https://gstreamer.freedesktop.org/documentation/vpx/vp8enc.html
 		// gstreamer1.0-plugins-good
 		if err := CheckPlugins([]string{"ximagesrc", "vpx"}); err != nil {
-			return nil, err
+			return "", err
 		}
 
 		pipelineStr = fmt.Sprintf(videoSrc + "vp8enc cpu-used=16 threads=4 deadline=1 error-resilient=partitions keyframe-max-dist=15 static-threshold=20" + appSink, pipelineDevice)
@@ -83,14 +84,14 @@ func CreateAppPipeline(codecRTP codec.RTPCodec, pipelineDevice string, pipelineS
 		// https://gstreamer.freedesktop.org/documentation/vpx/vp9enc.html
 		// gstreamer1.0-plugins-good
 		if err := CheckPlugins([]string{"ximagesrc", "vpx"}); err != nil {
-			return nil, err
+			return "", err
 		}
 
 		pipelineStr = fmt.Sprintf(videoSrc + "vp9enc cpu-used=16 threads=4 deadline=1 keyframe-max-dist=15 static-threshold=20" + appSink, pipelineDevice)
 	case "h264":
 		var err error
 		if err = CheckPlugins([]string{"ximagesrc"}); err != nil {
-			return nil, err
+			return "", err
 		}
 
 		// https://gstreamer.freedesktop.org/documentation/x264/index.html
@@ -107,12 +108,12 @@ func CreateAppPipeline(codecRTP codec.RTPCodec, pipelineDevice string, pipelineS
 			break
 		}
 
-		return nil, err
+		return "", err
 	case "opus":
 		// https://gstreamer.freedesktop.org/documentation/opus/opusenc.html
 		// gstreamer1.0-plugins-base
 		if err := CheckPlugins([]string{"pulseaudio", "opus"}); err != nil {
-			return nil, err
+			return "", err
 		}
 
 		pipelineStr = fmt.Sprintf(audioSrc + "opusenc bitrate=128000" + appSink, pipelineDevice)
@@ -120,7 +121,7 @@ func CreateAppPipeline(codecRTP codec.RTPCodec, pipelineDevice string, pipelineS
 		// https://gstreamer.freedesktop.org/documentation/libav/avenc_g722.html
 		// gstreamer1.0-libav
 		if err := CheckPlugins([]string{"pulseaudio", "libav"}); err != nil {
-			return nil, err
+			return "", err
 		}
 
 		pipelineStr = fmt.Sprintf(audioSrc + "avenc_g722" + appSink, pipelineDevice)
@@ -128,7 +129,7 @@ func CreateAppPipeline(codecRTP codec.RTPCodec, pipelineDevice string, pipelineS
 		// https://gstreamer.freedesktop.org/documentation/mulaw/mulawenc.html
 		// gstreamer1.0-plugins-good
 		if err := CheckPlugins([]string{"pulseaudio", "mulaw"}); err != nil {
-			return nil, err
+			return "", err
 		}
 
 		pipelineStr = fmt.Sprintf(audioSrc + "audio/x-raw, rate=8000 ! mulawenc" + appSink, pipelineDevice)
@@ -136,19 +137,15 @@ func CreateAppPipeline(codecRTP codec.RTPCodec, pipelineDevice string, pipelineS
 		// https://gstreamer.freedesktop.org/documentation/alaw/alawenc.html
 		// gstreamer1.0-plugins-good
 		if err := CheckPlugins([]string{"pulseaudio", "alaw"}); err != nil {
-			return nil, err
+			return "", err
 		}
 
 		pipelineStr = fmt.Sprintf(audioSrc + "audio/x-raw, rate=8000 ! alawenc" + appSink, pipelineDevice)
 	default:
-		return nil, fmt.Errorf("unknown codec %s", codecRTP.Name)
+		return "", fmt.Errorf("unknown codec %s", codecRTP.Name)
 	}
 
-	if pipelineSrc != "" {
+	return pipelineStr, nil
-		pipelineStr = fmt.Sprintf(pipelineSrc + appSink, pipelineDevice)
-	}
-
-	return CreatePipeline(pipelineStr)
 }
 
 // CreatePipeline creates a GStreamer Pipeline

internal/capture/manager.go

@@ -8,12 +8,12 @@ import (
 
 	"demodesk/neko/internal/types"
 	"demodesk/neko/internal/config"
+	"demodesk/neko/internal/capture/gst"
 )
 
 type CaptureManagerCtx struct {
 	logger       zerolog.Logger
 	mu           sync.Mutex
-	config       *config.Capture
 	desktop      types.DesktopManager
 	streaming    bool
 	broadcast    *BroacastManagerCtx
@@ -23,16 +23,49 @@ type CaptureManagerCtx struct {
 }
 
 func New(desktop types.DesktopManager, config *config.Capture) *CaptureManagerCtx {
+	logger := log.With().Str("module", "capture").Logger()
+
+	broadcastPipeline := gst.GetRTMPPipeline(
+		config.Device,
+		config.Display,
+		config.BroadcastPipeline,
+	)
+
+	screencastPipeline := gst.GetJPEGPipeline(
+		config.Display,
+		config.ScreencastPipeline,
+		config.ScreencastRate,
+		config.ScreencastQuality,
+	)
+
+	audioPipeline, err := gst.GetAppPipeline(
+		config.AudioCodec,
+		config.Device,
+		config.AudioParams,
+	)
+
+	if err != nil {
+		logger.Panic().Err(err).Msg("unable to get pipeline")
+	}
+
+	videoPipeline, err := gst.GetAppPipeline(
+		config.VideoCodec,
+		config.Display,
+		config.VideoParams,
+	)
+
+	if err != nil {
+		logger.Panic().Err(err).Msg("unable to get pipeline")
+	}
+
 	return &CaptureManagerCtx{
-		logger:      log.With().Str("module", "capture").Logger(),
+		logger:      logger,
-		mu:          sync.Mutex{},
-		config:      config,
 		desktop:     desktop,
 		streaming:   false,
-		broadcast:   broadcastNew(config),
+		broadcast:   broadcastNew(broadcastPipeline),
-		screencast:  screencastNew(config),
+		screencast:  screencastNew(config.Screencast, screencastPipeline),
-		audio:       streamNew(config.AudioCodec, config.Device, config.AudioParams),
+		audio:       streamNew(config.AudioCodec, audioPipeline),
-		video:       streamNew(config.VideoCodec, config.Display, config.VideoParams),
+		video:       streamNew(config.VideoCodec, videoPipeline),
 	}
 }
 

internal/capture/screencast.go

@@ -9,7 +9,6 @@ import (
 	"github.com/rs/zerolog"
 	"github.com/rs/zerolog/log"
 
-	"demodesk/neko/internal/config"
 	"demodesk/neko/internal/types"
 	"demodesk/neko/internal/capture/gst"
 )
@@ -17,7 +16,7 @@ import (
 type ScreencastManagerCtx struct {
 	logger       zerolog.Logger
 	mu           sync.Mutex
-	config      *config.Capture
+	pipelineStr  string
 	pipeline     *gst.Pipeline
 	enabled      bool
 	started      bool
@@ -28,22 +27,20 @@ type ScreencastManagerCtx struct {
 	image        types.Sample
 }
 
-func screencastNew(config *config.Capture) *ScreencastManagerCtx {
+const screencastTimeout = 5 * time.Second
+
+func screencastNew(enabled bool, pipelineStr string) *ScreencastManagerCtx {
 	manager := &ScreencastManagerCtx{
 		logger:       log.With().Str("module", "capture").Str("submodule", "screencast").Logger(),
-		config:      config,
+		pipelineStr:  pipelineStr,
-		enabled:     config.Screencast,
+		enabled:      enabled,
 		started:      false,
 		emitStop:     make(chan bool),
 		emitUpdate:   make(chan bool),
 	}
 
-	if !manager.enabled {
-		return manager
-	}
-
 	go func() {
-		ticker := time.NewTicker(5 * time.Second)
+		ticker := time.NewTicker(screencastTimeout)
 		manager.logger.Debug().Msg("started emitting samples")
 
 		for {
@@ -133,31 +130,20 @@ func (manager *ScreencastManagerCtx) stop() {
 
 func (manager *ScreencastManagerCtx) createPipeline() error {
 	if manager.pipeline != nil {
-		return fmt.Errorf("pipeline already running")
+		return fmt.Errorf("pipeline already exists")
 	}
 
 	var err error
 
 	manager.logger.Info().
-		Str("video_display", manager.config.Display).
+		Str("str", manager.pipelineStr).
-		Str("screencast_pipeline", manager.config.ScreencastPipeline).
 		Msgf("creating pipeline")
 
-	manager.pipeline, err = gst.CreateJPEGPipeline(
+	manager.pipeline, err = gst.CreatePipeline(manager.pipelineStr)
-		manager.config.Display,
-		manager.config.ScreencastPipeline,
-		manager.config.ScreencastRate,
-		manager.config.ScreencastQuality,
-	)
-
 	if err != nil {
 		return err
 	}
 
-	manager.logger.Info().
-		Str("src", manager.pipeline.Src).
-		Msgf("starting pipeline")
-
 	manager.pipeline.Start()
 	manager.sample = manager.pipeline.Sample
 	manager.emitUpdate <-true
@@ -170,6 +156,6 @@ func (manager *ScreencastManagerCtx) destroyPipeline() {
 	}
 
 	manager.pipeline.Stop()
-	manager.logger.Info().Msgf("stopping pipeline")
+	manager.logger.Info().Msgf("destroying pipeline")
 	manager.pipeline = nil
 }

internal/capture/stream.go

@@ -17,8 +17,7 @@ type StreamManagerCtx struct {
 	logger       zerolog.Logger
 	mu           sync.Mutex
 	codec        codec.RTPCodec
-	pipelineDevice  string
+	pipelineStr  string
-	pipelineSrc     string
 	pipeline     *gst.Pipeline
 	sample       chan types.Sample
 	emmiter      events.EventEmmiter
@@ -27,13 +26,11 @@ type StreamManagerCtx struct {
 	enabled      bool
 }
 
-func streamNew(codec codec.RTPCodec, pipelineDevice string, pipelineSrc string) *StreamManagerCtx {
+func streamNew(codec codec.RTPCodec, pipelineStr string) *StreamManagerCtx {
 	manager := &StreamManagerCtx{
 		logger:       log.With().Str("module", "capture").Str("submodule", "stream").Logger(),
-		mu:              sync.Mutex{},
 		codec:        codec,
-		pipelineDevice:  pipelineDevice,
+		pipelineStr:  pipelineStr,
-		pipelineSrc:     pipelineSrc,
 		emmiter:      events.New(),
 		emitUpdate:   make(chan bool),
 		emitStop:     make(chan bool),
@@ -103,7 +100,7 @@ func (manager *StreamManagerCtx) Enabled() bool {
 
 func (manager *StreamManagerCtx) createPipeline() error {
 	if manager.pipeline != nil {
-		return fmt.Errorf("pipeline already running")
+		return fmt.Errorf("pipeline already exists")
 	}
 
 	var err error
@@ -111,19 +108,14 @@ func (manager *StreamManagerCtx) createPipeline() error {
 	codec := manager.Codec()
 	manager.logger.Info().
 		Str("codec", codec.Name).
-		Str("device", manager.pipelineDevice).
+		Str("src", manager.pipelineStr).
-		Str("src", manager.pipelineSrc).
 		Msgf("creating pipeline")
 
-	manager.pipeline, err = gst.CreateAppPipeline(codec, manager.pipelineDevice, manager.pipelineSrc)
+	manager.pipeline, err = gst.CreatePipeline(manager.pipelineStr)
 	if err != nil {
 		return err
 	}
 
-	manager.logger.Info().
-		Str("src", manager.pipeline.Src).
-		Msgf("starting pipeline")
-
 	manager.pipeline.Start()
 
 	manager.sample = manager.pipeline.Sample
@@ -137,6 +129,6 @@ func (manager *StreamManagerCtx) destroyPipeline() {
 	}
 
 	manager.pipeline.Stop()
-	manager.logger.Info().Msgf("stopping pipeline")
+	manager.logger.Info().Msgf("destroying pipeline")
 	manager.pipeline = nil
 }