iridium/neko
2
2
Fork 0
mirror of https://github.com/m1k1o/neko.git synced 2024-07-24 14:40:50 +12:00
Code Issues Packages Projects Releases Wiki Activity

login logout proper http error handling.

Browse Source
This commit is contained in:
Miroslav Šedivý 2023-01-12 23:21:56 +01:00
parent b793e5b377
commit 6574470278
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
internal/api/session.go
View File

@ -1,6 +1,7 @@
package api package api
import ( import (
"errors"
"net/http" "net/http"
"github.com/demodesk/neko/pkg/auth" "github.com/demodesk/neko/pkg/auth"
@ -28,7 +29,13 @@ func (api *ApiManagerCtx) Login(w http.ResponseWriter, r *http.Request) error {
session, token, err := api.members.Login(data.Username, data.Password) session, token, err := api.members.Login(data.Username, data.Password)
if err != nil { if err != nil {
return utils.HttpUnauthorized().WithInternalErr(err) if errors.Is(err, types.ErrSessionAlreadyConnected) {
return utils.HttpUnprocessableEntity("session already connected")
} else if errors.Is(err, types.ErrMemberDoesNotExist) || errors.Is(err, types.ErrMemberInvalidPassword) {
return utils.HttpUnauthorized().WithInternalErr(err)
} else {
return utils.HttpInternalServerError().WithInternalErr(err)
}
} }
sessionData := SessionDataPayload{ sessionData := SessionDataPayload{
@ -51,7 +58,11 @@ func (api *ApiManagerCtx) Logout(w http.ResponseWriter, r *http.Request) error {
err := api.members.Logout(session.ID()) err := api.members.Logout(session.ID())
if err != nil { if err != nil {
return utils.HttpUnauthorized().WithInternalErr(err) if errors.Is(err, types.ErrSessionNotFound) {
return utils.HttpBadRequest("session is not logged in")
} else {
return utils.HttpInternalServerError().WithInternalErr(err)
}
} }
if api.sessions.CookieEnabled() { if api.sessions.CookieEnabled() {