Broadcast should not return error.

This commit is contained in:
Miroslav Šedivý
2020-11-18 20:30:33 +01:00
parent 3f4914d260
commit da7e6f7728
11 changed files with 103 additions and 90 deletions

View File

@ -142,7 +142,7 @@ func (manager *SessionManagerCtx) Members() []types.Session {
return sessions
}
func (manager *SessionManagerCtx) Broadcast(v interface{}, exclude interface{}) error {
func (manager *SessionManagerCtx) Broadcast(v interface{}, exclude interface{}) {
manager.membersMu.Lock()
defer manager.membersMu.Unlock()
@ -158,11 +158,9 @@ func (manager *SessionManagerCtx) Broadcast(v interface{}, exclude interface{})
}
if err := session.Send(v); err != nil {
return err
manager.logger.Warn().Err(err).Msgf("broadcasting event has failed")
}
}
return nil
}
// ---

View File

@ -67,20 +67,13 @@ func (session *SessionCtx) SetConnected(connected bool) {
}
func (session *SessionCtx) Disconnect(reason string) error {
if session.socket == nil {
return nil
}
// TODO: Refcator
if err := session.Send(&message.Disconnect{
Event: event.SYSTEM_DISCONNECT,
Message: reason,
}); err != nil {
return err
}
session.SetConnected(false)
return nil
return session.Send(
message.Disconnect{
Event: event.SYSTEM_DISCONNECT,
Message: reason,
})
}
func (session *SessionCtx) Send(v interface{}) error {