From e9502b0d9b3fd7c8af7ed7a4ae6764adbe2b6127 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miroslav=20=C5=A0ediv=C3=BD?= <sedivy.miro@gmail.com>
Date: Thu, 30 Sep 2021 19:42:25 +0200
Subject: [PATCH] session update mutex logic.

---
 internal/session/session.go | 47 ++++++++++++++++++++-----------------
 1 file changed, 26 insertions(+), 21 deletions(-)

diff --git a/internal/session/session.go b/internal/session/session.go
index e7d8a847..8cf08892 100644
--- a/internal/session/session.go
+++ b/internal/session/session.go
@@ -54,7 +54,7 @@ func (session *SessionCtx) IsHost() bool {
 }
 
 // ---
-// webscoket
+// websocket
 // ---
 
 func (session *SessionCtx) SetWebSocketPeer(websocketPeer types.WebSocketPeer) {
@@ -69,25 +69,27 @@ func (session *SessionCtx) SetWebSocketPeer(websocketPeer types.WebSocketPeer) {
 
 func (session *SessionCtx) SetWebSocketConnected(websocketPeer types.WebSocketPeer, connected bool) {
 	session.websocketMu.Lock()
-	if websocketPeer != session.websocketPeer {
-		session.websocketMu.Unlock()
+	isCurrentPeer := websocketPeer == session.websocketPeer
+	session.websocketMu.Unlock()
+
+	if !isCurrentPeer {
 		return
 	}
-	session.websocketMu.Unlock()
 
 	session.state.IsConnected = connected
 
 	if connected {
 		session.manager.emmiter.Emit("connected", session)
-	} else {
-		session.manager.emmiter.Emit("disconnected", session)
-
-		session.websocketMu.Lock()
-		if websocketPeer == session.websocketPeer {
-			session.websocketPeer = nil
-		}
-		session.websocketMu.Unlock()
+		return
 	}
+
+	session.manager.emmiter.Emit("disconnected", session)
+
+	session.websocketMu.Lock()
+	if websocketPeer == session.websocketPeer {
+		session.websocketPeer = nil
+	}
+	session.websocketMu.Unlock()
 }
 
 func (session *SessionCtx) GetWebSocketPeer() types.WebSocketPeer {
@@ -120,22 +122,25 @@ func (session *SessionCtx) SetWebRTCPeer(webrtcPeer types.WebRTCPeer) {
 
 func (session *SessionCtx) SetWebRTCConnected(webrtcPeer types.WebRTCPeer, connected bool) {
 	session.webrtcMu.Lock()
-	if webrtcPeer != session.webrtcPeer {
-		session.webrtcMu.Unlock()
+	isCurrentPeer := webrtcPeer == session.webrtcPeer
+	session.webrtcMu.Unlock()
+
+	if !isCurrentPeer {
 		return
 	}
-	session.webrtcMu.Unlock()
 
 	session.state.IsWatching = connected
 	session.manager.emmiter.Emit("state_changed", session)
 
-	if !connected {
-		session.webrtcMu.Lock()
-		if webrtcPeer == session.webrtcPeer {
-			session.webrtcPeer = nil
-		}
-		session.webrtcMu.Unlock()
+	if connected {
+		return
 	}
+
+	session.webrtcMu.Lock()
+	if webrtcPeer == session.webrtcPeer {
+		session.webrtcPeer = nil
+	}
+	session.webrtcMu.Unlock()
 }
 
 func (session *SessionCtx) GetWebRTCPeer() types.WebRTCPeer {